Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: import exponential back off header in rudder.h #551

Merged
merged 2 commits into from
Dec 9, 2024
Merged

chore: import exponential back off header in rudder.h #551

merged 2 commits into from
Dec 9, 2024

Conversation

timothybarraclough
Copy link
Contributor

This file appears to be missing from the umbrella header, and is now giving warnings in my CI pipeline.

It looks to me like it was introduced in this pull request.
#525

@timothybarraclough
Update Rudder.h
1a77509 
This feature didn't add the file file to the umbrella header, and is giving warnings in my CI pipeline.

rudderlabs#525
@timothybarraclough timothybarraclough requested a review from a team as a code owner November 13, 2024 23:27
@SKannaniOS
Copy link
Contributor

Hi, @timothybarraclough

Could you please provide the exact details regarding the warning? The warning description or screenshot would be helpful.

@timothybarraclough
Copy link
Contributor Author

This is the warning I'm receiving in my CI pipeline.
/Users/vagrant/Library/Developer/Xcode/DerivedData/cltruhqgzzzvwzaxtbuhfbksqqol/SourcePackages/checkouts/rudder-sdk-ios/Sources/Classes/Headers/Public/Rudder.h#L123: [/Users/vagrant/Library/Developer/Xcode/DerivedData/cltruhqgzzzvwzaxtbuhfbksqqol/SourcePackages/checkouts/rudder-sdk-ios/Sources/Classes/Headers/Public/Rudder.h#L123](/Users/vagrant/Library/Developer/Xcode/DerivedData/cltruhqgzzzvwzaxtbuhfbksqqol/SourcePackages/checkouts/rudder-sdk-ios/Sources/Classes/Headers/Public/Rudder.h#L123): Umbrella header for module 'Rudder' does not include header 'RSExponentialBackOff.h'

@contributor-support
Copy link

Thank you @timothybarraclough for contributing this PR.
Please sign the Contributor License Agreement (CLA) before merging.

@timothybarraclough
Copy link
Contributor Author

Hi there - Am I able to get a review on this please?

@SKannaniOS SKannaniOS changed the title Update Rudder.h chore: import exponential back off header in rudder.h Dec 9, 2024
SKannaniOS
SKannaniOS approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@SKannaniOS SKannaniOS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@SKannaniOS SKannaniOS merged commit b3b4a01 into rudderlabs:develop Dec 9, 2024
8 of 10 checks passed
@SKannaniOS
Copy link
Contributor

@timothybarraclough We have released this fix in the version v1.31.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SKannaniOS SKannaniOS SKannaniOS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timothybarraclough @SKannaniOS @gitcommitshow